diff --git a/sava-core/src/main/java/fr/agroclim/sava/core/MetricsBasicAuthServlet.java b/sava-core/src/main/java/fr/agroclim/sava/core/MetricsBasicAuthServlet.java index bc0faee0b9d87fc42d0d9f4e28be4769c4ad7078..47030608ed5735423e7c83ed6259723c3e1b1997 100644 --- a/sava-core/src/main/java/fr/agroclim/sava/core/MetricsBasicAuthServlet.java +++ b/sava-core/src/main/java/fr/agroclim/sava/core/MetricsBasicAuthServlet.java @@ -115,10 +115,13 @@ public class MetricsBasicAuthServlet extends MetricsServlet { SavaUtils.setGaugeValue("jvm_free_memory", (double) runtime.freeMemory()); // continue with the servlet super.doGet(req, resp); + return; } } catch (final Exception e) { LOGGER.warn("Received a bad request"); LOGGER.catching(Level.WARN, e); + resp.sendError(HttpServletResponse.SC_BAD_REQUEST); + return; } } resp.sendError(HttpServletResponse.SC_FORBIDDEN); diff --git a/sava-core/src/main/java/fr/agroclim/sava/core/SavaUtils.java b/sava-core/src/main/java/fr/agroclim/sava/core/SavaUtils.java index 9ac84b4d7dae4796180744560e06b35b9ece47bf..14968ffba1d54434935cb009ab1ee5bfe73824c7 100644 --- a/sava-core/src/main/java/fr/agroclim/sava/core/SavaUtils.java +++ b/sava-core/src/main/java/fr/agroclim/sava/core/SavaUtils.java @@ -149,7 +149,7 @@ public class SavaUtils { } catch (final Exception e) { LOGGER.warn("Gauge value MUST be a double. Otherwise getMetric.call() has failed." + " Please read stackstrace :"); - e.printStackTrace(); + LOGGER.catching(e); } };